Repository navigation
docs(readme): Lead "Get It" with Settings, not env vars - #1206
Merged
Merged
Conversation
Co-authored-by: Oded Messer <odedmesser@gmail.com>
omesser
commented
Sep 30, 2026
Owner
Author
There was a problem hiding this comment.
Soft-gate — CLEARED
Tip gated: 221d2bf6aa1a3ec79f27cd72e7548ae967aaf38c on cursor/readme-settings-get-it-6f3b (live re-fetch; matches handoff).
Scope: docs-only README.md (+12/−6). Draft: no. Closes #1185 (V1).
Soft ledger
| Soft | Status | Evidence |
|---|---|---|
| (a) #1185 / product intent | Met | Get It now leads with offline-with-no-key, then Settings → Character and Settings → AI (AI source / Harness · claude / Model API → Model / API: Base URL, Model, API key; Apply). No Harness-tab claim. Matches real UI tabs in src/settings.html / tests/settings-tabs.test.js: Presence, Character, AI, Chat, Privacy, Development — Harness lives under AI. Issue’s “Running It / Harness tab” wording correctly superseded by #1180 Get It + real tabs. |
| (b) Env secondary | Met | Env blocks demoted under “Developers and CI can override Settings with optional environment variables”; each example commented # Optional. Overrides Settings → …. Links to docs/harness.md#director-environment, #settings-and-keyring, and docs/DEVELOPMENT.md#character-packages (anchors exist on main). Those docs unchanged (README-only diff). |
| (c) Get It structure / coherence | Met | Keeps ## Get It (no Running It resurrection). Releases / cargo run -p fidget / Platform Support / Interact paths intact. Closes #1185 present and wired (closingIssuesReferences). |
| (d) Merge hygiene | Met | MERGEABLE vs main; mergeStateStatus: CLEAN (not CONFLICTING/DIRTY). |
| (e) CI on tip | Met | PR Tests: checks (ubuntu-latest), checks (macos-latest), windows — all SUCCESS on tip. Pages: build SUCCESS; deploy SKIPPED (expected on PR). No red failures. |
Hard (value-preservation)
Holds. Docs-only; Get It install/Releases/cargo run paths, Platform Support, Characters, Harness Support, and Interact not gutted. Env override path still documented as optional.
Verdict
CLEARED — Soft (a)–(e) Met; Hard Holds; CI green on tip. COMMENT only — do not merge / do not APPROVE from this gate.
— Cursor agent (Architect), on @omesser's behalf.
8 tasks done
This was referenced Oct 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Get It still taught the first configuration as
FIDGET_HARNESSandFIDGET_CHARACTERoncargo run. Those variables override Settings. The window already has Character and AI, and a reader who copies the shell block never opens it.What changed
Get It now configures from Settings, after the offline-with-no-key line. Character is Settings → Character. A Harness or a Model API is Settings → AI: AI source (
Harness · claude, or Model API), then Model / API for Base URL, Model, and API key. The Settings window has no Harness tab. The issue text still says Running It and a Harness tab. #1180 renamed the heading to Get It, and the tabs are Presence, Character, AI, Chat, Privacy, and Development.The env examples stay, labeled optional, for developers and CI. The full list points at
docs/harness.md#director-environmentanddocs/DEVELOPMENT.md#character-packages. Those docs are unchanged. No product behavior change.How to verify
Docs only. The primary path in Get It, before any
FIDGET_*line:No manual check.
Closes #1185
— Cursor agent, on @omesser's behalf.